Conversation
This comment was marked as resolved.
This comment was marked as resolved.
|
Fixed link, thanks. |
|
We could certainly move all the commits into a single PR and the test and review that again. Let's wait for a first round of reviews on both current PRs to settle, then we'll take it from there. |
|
@tkoeppe by the way, you've put the milestone date for 2025-06 as 06-31. Is that actually correct? I was under the impression that we would want to have the updated working draft in the post-Sofia mailing, if not sooner so that the ISO review process can start ASAP. |
|
@eisenwave Sorry, no idea, I don't recall making that label or how it was made. Don't worry about it. We're not going to stop the process because of what a label says. |
|
That milestone is by me. I've moved the date to 07-15. |
dec16ef to
f07c133
Compare
source/meta.tex
Outdated
| @@ -2554,6 +2570,3461 @@ | |||
| \end{example} | |||
| \end{itemdescr} | |||
|
|
|||
| %FIXME: The paper doesn't actually specify that this subclause should exist, | |||
There was a problem hiding this comment.
Sounds good, except that'd like to have a global rename of "meta.reflection*" labels to "meta.refl*" for space economy (without loss of clarity, in my view).
There was a problem hiding this comment.
It may be better to do this as a bulk change after motions. There are quite a lot of reflections papers that would all need individual fixups otherwise, and it's making it more complicated than it needs to be.
|
I'll resolve those comments today. @jensmaurer when you said that types always use code font, does that mean that any use of e.g. The paper makes these italic, so I assume that's Also, does every FIXME require its own fixup commit? If yes, then there are like 20 incoming commits that each add one comma ... |
No, one big commit is good enough. This will be squashed anyway. For T, in general, we use T and U as type variables in upright code font, even if they are sort-of meta-variables. (If something could be a valid C++ snippet, we use upright code font.) Since an expression cannot always be written \tcode{E} (value category and bit-field-ness are not expressible as "E"), we use I suggest you leave |
37c4fbf to
178a7f4
Compare
|
Alright, the PR is now in a state where all the little comma FIXME and other minor things are resolved. I'd hold off on major changes like renaming to |
36c489f to
0235e5d
Compare
…lock for the class definition
…eblock for the class definition
107d5f5 to
7ccaeba
Compare
Feel free to cherry-pick into #8004 once @eisenwave is done with the library part.
Fixes #7930
Fixes cplusplus/papers#1668